Timer CSP check should report an exception when it fails

Open Beginner friendly
#44,871 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
rust
Domain
security, web-dev

Research direction

Read the timer initialization steps at the linked HTML specification section, then inspect components/script/timers.rs around lines 663-676 and 796. Move the CSP check to the indicated point so a failed check reports an exception as required by step 9.8.3.

Written by the indexing model from the issue text.

Description

A-content/dom

https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timer-initialisation-steps step 9.8.3

https://github.com/servo/servo/blob/fdc676979b2257cbf0e123f1c03233fedcd1ad12/components/script/timers.rs#L663-L676

It looks like we're performing the check too early; we should be performing it inside https://github.com/servo/servo/blob/fdc676979b2257cbf0e123f1c03233fedcd1ad12/components/script/timers.rs#L796 instead.

Dominant language
Rust
Stars
38k
Forks
3.8k
Avg merge
1d 8h
Merged PRs (30d)
459

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from servo/servo

All issues in servo/servo

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.