servo / servo/servo

Webdriver script execution doesn't follow script execution preparation steps

Open
#35,751 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-content/script A-webdriver
Dominant language
Rust
Stars
38k
Forks
3.8k
Avg merge
1d 6h
Merged PRs (30d)
465

Description

This causes a panic in tests/wpt/tests/webdriver/tests/classic/execute_script/node.py::test_not_supported_nodes[document] when the Location implementation tries to obtain the entry settings global and the settings stack is empty.

https://w3c.github.io/webdriver/#dfn-execute-a-function-body
https://html.spec.whatwg.org/multipage/webappapis.html#prepare-to-run-script
https://html.spec.whatwg.org/multipage/webappapis.html#prepare-to-run-a-callback

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running tests/wpt/tests/webdriver/tests/classic/execute_script/node.py::test_not_supported_nodes[document] and inspect the WebDriver execute-a-function-body behavior. Compare it with the HTML “prepare to run script” and “prepare to run a callback” algorithms linked in the issue. Done means the test no longer panics and script execution follows those preparation steps.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing-qa, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.