servo / servo/rust-url

Host should implement deserialize to parse strings

Open
#895 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

Right now, trying to deserialize a domain.name.com to a Host leads to:

unknown variant domain.name.com, expected one of Domain, Ipv4, Ipv6'

Probably implementing deserialize manually with the host::parse would fix this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with host::parse and the Host deserialization path. Reproduce deserialization of a string such as domain.name.com, then update the deserialization behavior so valid host strings are parsed rather than treated as enum variants. Done means the example no longer produces the unknown-variant error and existing behavior remains covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.