servo / servo/rust-url

Add parameter spaceAsPlus to ByteSerialize

Open
#888 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

Hello! I think it would be nice to be able to enable/disable replacing "%20" with "+" in ByteSerialize struct.

This parameter and its usage described here https://url.spec.whatwg.org/#string-percent-encode-after-encoding

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating ByteSerialize in the rust-url source and read the linked WHATWG URL specification section on string percent-encode after encoding. Add a configurable spaceAsPlus option so the existing %20-to-+ behavior can be enabled or disabled, then verify both output forms with the relevant serialization tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.