servo / servo/rust-url

percent_encoding::NON_ALPHANUMERIC should be configurable

Open
#871 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

There are use cases where it does more harm (by affecting the readability of a URL) than good if too many non-ASCII chars are %-encoded. It would be possible to change that without breaking the API by adding Cargo features for the non-ASCII chars (or groups, as in the URL Standard). This would also enable projects to configure this set, that indirectly use this crate though a depedency.

If that's an option, I'll be happy to make a PR for this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by reviewing the crate's percent-encoding API and the linked URL Standard section, then define how Cargo features should group non-ASCII characters while preserving existing behavior. Done means projects can configure the encoded set without breaking the current API.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design, build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.