servo / servo/rust-url

set scheme with non-tab/newline C0 controls should result in no-op

Open
#815 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

currently, we're trimming C0 controls and also whitespaces; however, leading/trailing C0 controls are invalid for setting scheme.

following tests are related wpt tests:

https://github.com/web-platform-tests/wpt/blob/f72c88ab79843a46ffdf63264e833121811f08d9/url/resources/setters_tests.json#L291-L323

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the scheme setter implementation and its related tests in rust-url, then compare the behavior with the linked WPT setters_tests.json cases at lines 291-323. Verify that leading or trailing non-tab/newline C0 controls do not alter the scheme, and add or update coverage until the behavior matches those tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.