servo / servo/rust-url

`host` returns `Host::Domain` with custom protocols even though it is an IP address

Open
#767 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

This should at least be documented as a pitfall.

use url::Url;
fn main() {
    println!("{:?}", Url::parse("http://127.0.0.1").unwrap().host());
    println!("{:?}", Url::parse("custom://127.0.0.1").unwrap().host());
}
$ cargo run
[…]
Some(Ipv4(127.0.0.1))
Some(Domain("127.0.0.1"))

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the Rust reproduction in the issue and inspect the project's existing documentation for Url::host and custom protocols. Document that the same IP-like value is classified differently for HTTP and custom schemes, with the two shown outputs serving as the expected pitfall.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.