servo / servo/rust-url

Prefer 'kind' to 'type_' in data-url

Open
#589 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

https://github.com/servo/rust-url/blob/28314752bf138a87bd8151f610d385629dec5710/data-url/src/mime.rs#L7

I know that this will be a breaking change, but type_ is just too ugly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at data-url/src/mime.rs line 7 and inspect the existing type_ declaration and its usages. Rename it to kind, then verify that the affected data-url code and any relevant tests still build and pass with the breaking API change.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.