servo / servo/rust-url

Does not return ParseError for invalid Url

Open
#552 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.6k
Forks
406
PR merge metrics
No merged PRs in 30d

Description

use url::Url;

fn main() {
    println!("{:?}", Url::parse("http://\""));
}

Outputs:

Ok("http://\"/")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue's Rust example with Url::parse("http://"") and trace the URL parser entry point that accepts the quoted character. Add a regression test showing that this input returns ParseError, then run the relevant parser test suite to confirm valid URLs remain unaffected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.