Url::from_file_path fails on cygwin

Open
#434 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
api

Research direction

Start at Url::from_file_path and the path_to_url_segments_windows path, then determine how Cygwin paths such as /cygdrive/c/... should be handled and whether conversion belongs in this library or its caller. Done means the responsibility and expected behavior for Cygwin paths are decided and the relevant behavior is verified.

Written by the indexing model from the issue text.

Description

windows

I am not sure if this is the right place to report this, but since Url is the library which returns the error, I figured I'd start here. Feel free to redirect me to a better place and close this if I am utterly mistaken.

When trying to use languageclient-neovim on Cygwin I get errors originating from languageclient trying to convert a file path to a URL: path_to_url_segments_windows errors out on anything that is neither a drive letter or UNC path, so it fails when given a Cygwin path like /cygdrive/c/.... I am not sure if this is something, the method should be able to handle or if it should be the caller's responsibility to do a conversion beforehand, so I'm opening this just in case.

Dominant language
Rust
Stars
1.6k
Forks
406
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from servo/rust-url

All issues in servo/rust-url

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.