allow v2 to always compile in MSRV with no features enabled
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.7k
- Forks
- 216
- Avg merge
- 17h 50m
- Merged PRs (30d)
- 95
Description
yeah as of now, no default features = nightly only. once the allocator API stabilizes then it will use the proper API when the feature is disabled
I'm not sure but it seems wrong to me, I know no other crate that fails to compile with no default feature which usually means less strict, You might want to get some other feedback about it from the community.
Originally posted by @fereidani in https://github.com/servo/rust-smallvec/issues/630#issuecomment-5743693235
instead, what we would do is have a allocator-api feature that does not then require the allocator-api2 dependency and use alloc, whilst when it is disabled it defaults to allocator-api2
it's just the inverse of what we have
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect v2's feature and dependency configuration, especially the allocator-api and allocator-api2 relationship. First try compiling with the MSRV and no default features, then verify the inverse feature behavior using alloc when allocator-api is enabled and allocator-api2 when it is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100