servo / servo/rust-harfbuzz

Bundled build with `freetype` doesn't actually work

Open
#235 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
90
Forks
68
PR merge metrics
No merged PRs in 30d

Description

When we build with --features bundled, we need to add this to the harfbuzz-sys/build.rs:

if cfg!(feature = "freetype") {
    cfg.define("HAVE_FREETYPE", "1");
}

Unfortunately, this will fail as we need to set up additional build flags for the build to find freetype (and this is even more unfriendly on Windows).

This gets a bit annoying when freetype is in the default features ...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in harfbuzz-sys/build.rs and reproduce the bundled build with the freetype feature enabled. Investigate the additional build flags needed for freetype discovery, including the Windows case. Done means the bundled build with freetype succeeds rather than failing to locate freetype.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.