Merge style_traits::ToCss trait into cssparser::ToCss
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 869
- Forks
- 152
- Avg merge
- 15h 8m
- Merged PRs (30d)
- 12
Description
cssparser and style_traits both have ToCss that are very similar, but have some slight differences. In order to simplify implementations, I'm happy to do the work to merge these (including the macro from style_derive into cssparser-macros), but I wanted to make sure there wasn't a reason for the split before I got started?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing cssparser/src/serializer.rs#L14 with stylo/style_traits/values.rs#L78 to identify the differences between the two ToCss traits. Then inspect the style_derive macro and cssparser-macros to determine the merge scope. Done means the duplicated trait and macro functionality are consolidated without losing the existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- web-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100