servo / servo/rust-cssparser

cargo fmt does not work through macros

Open
#385 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Rust
Stars
869
Forks
152
Avg merge
15h 8m
Merged PRs (30d)
12

Description

Some macros have match bodies inside, e.g. match_byte and match_ignore_ascii_case and the formatter skips those bodies.

Some of them are quite big, like here: src/tokenizer.rs:560

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the match_byte and match_ignore_ascii_case macros, especially the example at src/tokenizer.rs:560, and run cargo fmt to reproduce the skipped formatting. Trace how these macro match bodies are represented and formatted; done means cargo fmt formats the bodies instead of leaving them unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.