servo / servo/rust-cssparser

Token usage of CowRcStr and NonNull/Rc<String> makes it non Send

Open
#370 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Rust
Stars
869
Forks
152
Avg merge
15h 8m
Merged PRs (30d)
12

Description

And it is required by anyhow in async functions.

To reproduce, try to compile this code

use scraper::Selector;
#[tokio::main]
async fn main() -> anyhow::Result<()> {
    let selector = Selector::parse("#top")?;
    Ok(())
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by compiling the provided Tokio and anyhow reproduction, then trace Selector::parse and the CowRcStr and NonNull/Rc types implicated in the Send error. Done means the example compiles successfully in an async function without changing the reproduction's intended use.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.