servo / servo/rust-cssparser

Add benchmark tests for color parsing

Open
#319 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Rust
Stars
869
Forks
152
Avg merge
15h 8m
Merged PRs (30d)
12

Description

Spinning off from #314:

With the complexities involved with parsing colors, there are concerned about regressing the time it takes to parse them.

Per @emilio:

But it should be rather trivial to add a few benchmarks for color parsing in src/tests.rs like we have for data: uris etc?

We should look into that.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/tests.rs and review the existing data: URI benchmarks. Add a few benchmarks covering color parsing, then compare their results to ensure parsing performance can be tracked for regressions. Done means the color-parsing benchmarks are present alongside the existing benchmarks.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance, testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.