servo / servo/mozjs

CI: Reverting the version (to a lower number) should fail the version bump check

Open
#672 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
359
Forks
153
Avg merge
2d 10h
Merged PRs (30d)
8

Description

https://github.com/servo/mozjs/pull/670 was a revert PR, that also reverted the version number. I'm leaning towards that we probably want to fail CI in such cases and require bumping the number.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the version-bump CI check and PR 670, which reverted the version number. Determine where a lower version is accepted and update the check so CI rejects it; done when a version decrease fails CI while a valid bump still passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.