servo / servo/mozangle

Cannot build Servo on MacOS because of an error in mozangle's build.rs.

Open
#92 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
48
Forks
30
Avg merge
16h 45m
Merged PRs (30d)
5

Description

The #include <array> line in gfx/angle/checkout/include/GLSLANG/ShaderLang.h is not working on MacOS.

This is breaking ./mach build on a fresh servo clone (servo commit: 6bad65a5a16c5a90b09fe8d0441c1d473e46e060)

--- stderr
  gfx/angle/checkout/include/GLSLANG/ShaderLang.h:13:10: fatal error: 'array' file not found

  thread 'main' panicked at [...]/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/mozangle-0.5.3/build.rs:371:10:
  Should generate shader bindings: ClangDiagnostic("gfx/angle/checkout/include/GLSLANG/ShaderLang.h:13:10: fatal error: 'array' file not found\n")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with gfx/angle/checkout/include/GLSLANG/ShaderLang.h and the binding-generation path at mozangle's build.rs:371. Reproduce the failure with ./mach build on a fresh macOS Servo clone at commit 6bad65a5a16c5a90b09fe8d0441c1d473e46e060, then trace why the C++ standard header is not found. Done means the fresh clone builds without the missing 'array' diagnostic.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, macos, rust
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.