servo / servo/mozangle

Can't build with new versions of cc-rs when using sccache

Open
#38 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
48
Forks
30
Avg merge
16h 45m
Merged PRs (30d)
5

Description

Linux builds break with this error:

running: "sccache" "clang++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=x86_64-unknown-linux-gnu" "-I" "gfx/angle/checkout/include/" "-I" "gfx/angle/checkout/out/gen/angle/" "-I" "gfx/angle/checkout/src/" "-I" "gfx/angle/checkout/src/common/third_party/base/" "-std=c++14" "-msse2" "-DANGLE_ENABLE_DEBUG_ANNOTATIONS" "-DANGLE_ENABLE_ESSL" "-DANGLE_ENABLE_GLSL" "-DANGLE_ENABLE_HLSL" "-DANGLE_ENABLE_KEYEDMUTEX" "-DANGLE_SKIP_DXGI_1_2_CHECK" "-DDYNAMIC_ANNOTATIONS_ENABLED=1" "-DNOMINMAX" "-DNTDDI_VERSION=0x0A000003" "-DUNICODE" "-DWINVER=0x0A00" "-D_ATL_NO_OPENGL" "-D_CRT_RAND_S" "-D_CRT_SECURE_NO_DEPRECATE" "-D_HAS_EXCEPTIONS=0" "-D_SCL_SECURE_NO_DEPRECATE" "-D_SECURE_ATL" "-D_UNICODE" "-D__NDK_FPABI__=" "-o" "/repo/target/debug/build/mozangle-b2466e97cbb8dddf/out/gfx/angle/checkout/src/common/third_party/xxhash/xxhash.o" "-c" "gfx/angle/checkout/src/common/third_party/xxhash/xxhash.c"
exit code: 0
cargo:warning=error: invalid argument '-std=c++14' not allowed with 'C'
exit code: 1

Building with updated cc-rs and without sccache does not trigger this error. I suspect https://github.com/alexcrichton/cc-rs/commit/4b72474342c3d75d5122f7fec446018adf25e5e0 triggers the change in behaviour.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Linux build using sccache and compare it with an updated cc-rs build without sccache. Start with the cc-rs behavior around commit 4b72474342c3d75d5122f7fec446018adf25e5e1 and the xxhash.c compilation command; done means the C source builds without receiving the invalid -std=c++14 argument.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.