servo / servo/html5ever

TreeSink requires `Tendril<UTF8, NonAtomic>`?

Open
#430 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.6k
Forks
288
Avg merge
2d 22h
Merged PRs (30d)
8

Description

Is there a reason that we can't implement TreeSink using Atomic Tendrils? I'm trying to use an HTML library built on top of html5ever in a future and it seems that I am unable to because of StrTendril being !Send. I tried swapping out the Tendril used by the tree builder to be Atomic but it seems that once I do that I can no longer implement TreeSink.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the TreeSink trait and the Tendril type used by the tree builder in html5ever. The issue does not name files or tests, and it does not define a concrete change; first determine whether Atomic Tendrils can be supported and what API or trait adjustments that would require.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.