rcdom's node's destructor clears all children for nodes that can have strong references outside of the tree
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.6k
- Forks
- 288
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 8
Description
#409 contains this code:
// If this is not the only strong reference, don't drop any children, because
// apparently somebody else wants them. Just let our reference drop instead.
if Rc::strong_count(&root) > 1 {
continue;
}
Our current implementation does not perform this check, but presumably this isn't a case that affects our tests which are largely concerned with the tree structure.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing rcdom's node destructor with the strong-reference check shown from issue #409, then inspect the existing tests that cover tree structure. Done means children are not cleared when a node has strong references outside the tree, with coverage for that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100