servo / servo/highfive

Add a warning about use of from_marked_location

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
281
Forks
52
PR merge metrics
No merged PRs in 30d

Description

We don't run highfive on rust-mozjs yet, but this is one of those dangerous constructs that it would be nice to warn about.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating how highfive implements existing source warnings, then inspect how the from_marked_location construct appears in rust-mozjs. Done means highfive emits a warning for this construct, with coverage added if the repository has tests for warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.