don't remove awaiting-review label if the approval is not sufficient
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 281
- Forks
- 52
- PR merge metrics
- No merged PRs in 30d
Description
Currently an approving review from a non maintainer will remove the label, even though it's not sufficient for a merge and an authorized review by a maintainer is still required.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Python code that handles approving reviews and removes the awaiting-review label. Verify how maintainer authorization is determined; done means a non-maintainer approval leaves the label in place, while sufficient maintainer approval can remove it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100