servo / servo/highfive

Consider adding sizing labels for pull requests

Open
#224 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
281
Forks
52
PR merge metrics
No merged PRs in 30d

Description

https://github.com/mdn/browser-compat-data has different labels that are automatically applied to pull requests based on their size.
For example, a PR that updates 0-6 LoC will get the size:xs label, whereas one that updates 25-100 LoC will get size:m.

These labels serve two purposes:

  • They can hint to the author that the PR should be split up into smaller changes (size:xl)
  • They (roughly) indicate to reviewers how much effort it is to review the PR, without first having to click on it

I think these labels are useful and it would be nice to have the highfive bot apply them to servo PRs. Might be a bit noisy though, we would have to see.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing how highfive handles pull-request events and applies labels, then determine how changed lines are counted and how size thresholds should map to labels. Done means pull requests receive size labels based on their change size without disrupting existing labeling.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.