Do not notify label watcher who is already participating
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 281
- Forks
- 52
- PR merge metrics
- No merged PRs in 30d
Description
Currently, highfive will cc a label watcher on an issue even if they have already commented or been mentioned. @mbrubeck has been triaging a ton of issues lately (which is awesome), but the aforementioned behavior means highfive is leaving unnecessary comments; see https://github.com/servo/servo/issues/11167 for an example where I am already participating in the issue.
This will require changes to APIProvider and GithubAPIProvider in newpr.py, as well as TestAPIProvider in test.py, to add a method to get the list of participants on an issue.
Files:
newpr.pyhandlers/label_watchers/__init__.py- Add a test to
handlers/label_watchers/tests
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in newpr.py with APIProvider and GithubAPIProvider, then inspect TestAPIProvider in test.py and the label-watcher handler at handlers/label_watchers/init.py. Review the existing tests under handlers/label_watchers/tests and add coverage showing that a watcher who has commented or been mentioned is not notified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, python
- Domain
- api, backend, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100