Should we check the diffs whenever new code is committed?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 281
- Forks
- 52
- PR merge metrics
- No merged PRs in 30d
Description
In servo/servo#11267, the author modified the stuff inside python, and I was notified by highfive when the PR was opened. Later, new commits were added, where the author went for modifying the CI scripts (whose watcher is @aneeshusa). Wouldn't it be better if he got notified by it?
I suggest we should check the diff whenever new code is committed. We should probably store the state of the notified watchers somehow and check it before notifying someone again (so that we don't thrash the PR with comments!).
Whenever I think of a new suggestion, I'm worried about #124. Then, there's the problem of feasibility. Can we actually do this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the watcher notification flow and the behavior described in servo/servo#11267, including the later CI-script commit. Done would mean deciding whether new commit diffs trigger newly relevant watcher notifications without repeating notifications already sent; issue #124 is also noted as related.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100