servo / servo/font-kit

Stub get_fallbacks

Open
#257 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
840
Forks
137
Avg merge
4h 56m
Merged PRs (30d)
1

Description

I'm looking for the fallback implementation, but I seen this:

/// Get font fallback results for the given text and locale.
///
/// Note: this is currently just a stub implementation, a proper implementation
/// would likely use FontConfig, at least on Linux. It's not clear what a
/// FreeType loader with a non-FreeType source should do.
fn get_fallbacks(&self, text: &str, _locale: &str) -> FallbackResult<Font> {
    warn!("unsupported");
    FallbackResult {
        fonts: Vec::new(),
        valid_len: text.len(),
    }
}

And blame tells me that It's been added 5 years ago by comments, but It seems
like no body is working on this. I hope it can be implemented.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the get_fallbacks entry point and trace how fallback results are expected to be used. Investigate the noted FontConfig approach on Linux and decide how a FreeType loader with a non-FreeType source should behave. Done means the stub is replaced with a proper fallback implementation and the unresolved source behavior has been settled.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.