serverless / serverless/examples
origin control policy is wrong
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.5k
- Forks
- 4.4k
- Avg merge
- 2h 55m
- Merged PRs (30d)
- 3
Description
examples/aws-node-single-page-app-via-cloudfront/serverless.yml:52 - ie. line 52, there is:
OriginProtocolPolicy: https-only
This is exactly wrong - it should be http-only.
Apart from many other reasons why people would use cloudfront instead of plain-jane s3, one very important one is that you can serve https from it. Not so for S3. S3 is the origin. OriginProtocolPolicy indicates the protocol that cloudfront uses to fetch the assets from s3. and https is not supported by s3.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open examples/aws-node-single-page-app-via-cloudfront/serverless.yml at line 52 and verify the CloudFront origin protocol setting. Done means the OriginProtocolPolicy value is changed from https-only to http-only; no test file is mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100