serde-rs / serde-rs/serde-rs.github.io

security note for deriving Deserialize on types with invariants

Open
#74 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
23
Forks
109
PR merge metrics
No merged PRs in 30d

Description

When deriving Deserialize, it should be ensured that invariants of the types cannot be violated by deserializing untrusted data. This is especially important if the invariants are trusted by unsafe code.
I checked but couldn't find such a note in the docs currently.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No documentation file or test is named. Start by locating the documentation for deriving Deserialize and review the existing guidance on untrusted input and type invariants. Add a security note explaining that deserialization must not violate invariants, especially when unsafe code relies on them, then verify the documentation builds if the repository provides a documentation check.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.