sequelize / sequelize/sequelize
queryInterface.removeIndex with a wrong name
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 30.4k
- Forks
- 4.3k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 68
Description
What are you doing?
Creating migrations and testing them: db:migrate then db:migrate:undo
What do you expect to happen?
Doing it with addIndex and removeIndex with a wrong name I'd expect it to fail and complain.
What is actually happening?
But it just removed the migration from SequelizeMeta and said all is OK. However the index was not removed! And the next db:migrate failed!
Dialect: sqlite
Dialect version: 3
Sequelize version: 4.38.0
Sequelize cli version: 4.1.0
Tested with latest release: Yes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the SQLite migration sequence with db:migrate and db:migrate:undo, using queryInterface.removeIndex with an incorrect name. Check that the failed removal reports an error and leaves SequelizeMeta and the index state consistent; the issue does not name a specific file or test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js, sqlite
- Domain
- cli, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100