sequelize / sequelize/sequelize
Sequelize adds id(PK) of main table in findAll with 'group' and currupts a query with it in posgre.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 30.4k
- Forks
- 4.3k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 68
Description
Hello! I have Products model, and Vendors model. With assocation that Vendor has many products and product has one vendorId. I need filter vendors by product properties and/or vendor properties. Using postgre 9.6 and camelcase columns. Sequelize 3.30.2
Therefore object for querying:
Products.findAll({
attributes: [],
where: { type: 'service' },
include: [{model: Vendors, attributes: ['id', 'name', 'description'], as: 'vendor', required: true, where: { approved: true } }],
group: ['vendor.id']
})
Generates incorrect query (with "Products"."id"):
SELECT "Products"."id", "vendor"."id" AS "vendor.id", "vendor"."name" AS "vendor.name", "vendor"."description" AS "vendor.description" FROM "Products" AS "Products" INNER JOIN "Vendors" AS "vendor" ON "Products"."vendorId" = "vendor"."id" AND "vendor"."approved" = true WHERE "Products"."type" = 'service' GROUP BY "vendor"."id";
Query without "Products"."id" works fine and returns vendorId`s filtered by vendor parameters (or/and product parameters):
SELECT "vendor"."id" AS "vendor.id", "vendor"."name" AS "vendor.name", "vendor"."description" AS "vendor.description" FROM "Products" AS "Products" INNER JOIN "Vendors" AS "vendor" ON "Products"."vendorId" = "vendor"."id" AND "vendor"."approved" = true WHERE "Products"."type" = 'service' GROUP BY "vendor"."id";
Is any way to tell Sequelize to not include primary key if I don`t want it in attributes?
Thanks!
upd. workaround https://github.com/sequelize/sequelize/issues/7534#issuecomment-881615707
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Products.findAll reproduction using attributes: [], an included vendor, and group: ['vendor.id']; compare the generated PostgreSQL SQL with the working query shown in the issue. Review the workaround in the linked comment and verify that the completed behavior omits Products.id while preserving the vendor fields and filtering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs, postgresql
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100