sequelize / sequelize/sequelize

[MSSQL]DataTypes.STRING should be Varchar or NVarchar ?

Open
#6,036 14 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
30.4k
Forks
4.3k
Avg merge
1d 6h
Merged PRs (30d)
68

Description

version:3.19.3

http://docs.sequelizejs.com/en/latest/api/datatypes/

according to the docs, DataTypes.STRING should be map to Varchar. but i got nvarchar in mssql ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DataTypes.STRING behavior described in the issue and compare the documentation at the linked datatypes API page with the MSSQL-generated type in version 3.19.3. Done means the documented mapping and observed MSSQL behavior are reconciled, with the relevant documentation or behavior clarified.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.