semantic-release / semantic-release/release-notes-generator

Link in commit creates unwanted `closes` message in release notes

Open
#788 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
368
Forks
55
Avg merge
10m
Merged PRs (30d)
1

Description

Running on a self-hosted GitLab instance, given the following commit:

git commit -m "fix(cache): lock retry" -m "see https://github.com/mike-marcacci/node-redlock/issues/168#issuecomment-2369328838"

Creates

### Bug Fixes
    * cache: lock retry (78e2a9d (https://my-gitlab-domain/my-group/my-project/commit/78e2a9d924586365dceb302cae2746a24ea43839)), closes /github.com/mike-marcacci/node-redlock/issues/168#issuecomment-2369328838 (https://my-gitlab-domain/my-group//github.com/mike-marcacci/node-redlock/issues/168/issues/issuecomment-2369328838)

Note: the (unwanted) link is invalid too https://my-gitlab-domain/my-group//github.com/mike-marcacci/node-redlock/issues/168/issues/issuecomment-2369328838

My apologies if this is the wrong repo (could be semantic-release/commit-analyzer)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported output in semantic-release/release-notes-generator with the supplied commit message and self-hosted GitLab setup. Trace how the commit body URL becomes a closes reference, and compare whether the behavior belongs here or in semantic-release/commit-analyzer. Done means the external GitHub URL is not converted into an invalid closes link.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.