semantic-release / semantic-release/gitlab

Documentation improvements.

Open
#258 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

docs
Dominant language
JavaScript
Stars
344
Forks
89
Avg merge
16h 11m
Merged PRs (30d)
4

Description

I think it's a better to make these example uniform, it's really confusing.

semantic-release/gitlab (this project)

{
  "plugins": [
    "@semantic-release/commit-analyzer",
    "@semantic-release/release-notes-generator",
    ["@semantic-release/gitlab", {
      "gitlabUrl": "https://custom.gitlab.com",
      "assets": [
        {"path": "dist/asset.min.css", "label": "CSS distribution"},
        {"path": "dist/asset.min.js", "label": "JS distribution"}
      ]
    }],
  ]
}
  1. It's not clear from the above how to publish an angular project, which builds into dist hand has many "assets". npm pack just needs to be told to the dist/ directory that contains the package.json, for example npm pack dist/my-workspace/my-lib. How do we package an angular project with Semantic-Release gitlab like above?
  2. You post a gitlabUrl in there. It's not clear why I would ever want that. That can be supported by the package.json. Why would I want it here. For simplicity I would remove it.

GitLab wiki,

The following is from the GitLab wiki,

{
  "branches": ["master"],
  "plugins": [
    "@semantic-release/commit-analyzer",
    "@semantic-release/release-notes-generator",
    "@semantic-release/gitlab",
    "@semantic-release/npm",
    [
      "@semantic-release/git",
      {
        "assets": ["package.json"],
        "message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
      }
    ]
  ]
}
  1. Note this has branches That seems to be required. If it is this project should probably also contain it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the two configuration examples in the issue and compare them with the linked GitLab wiki example. Clarify how an Angular project with a dist package is packaged, explain or remove the gitlabUrl example, and establish whether branches belongs in the project example. Done means the documentation presents uniform, unambiguous configurations and answers these questions.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript
Domain
documentation, release
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.