semantic-release / semantic-release/github

Re-Tag pre-release correctly on production as latest release

Open
#608 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
534
Forks
150
Avg merge
1m
Merged PRs (30d)
3

Description

Hi!

I'm not sure what the thought process behind the current behaviour is, but for me I'm not sure why a master release to an existing pre-release won't mark the release on github as the latest release.

Semantic-release for NPM has that behaviour as I would expect.

To clarify what I mean:

  1. Use this simple releaserc config (and this GH action)
  2. Push a release-relevant commit to the next branch
  3. Release CI will run and correctly publish a:
    • x.x.x@next NPM package
      Screenshot 2023-03-21 at 13 25 47
    • x.x.x GitHub release tagged as pre-release
      Screenshot 2023-03-21 at 13 24 09
  4. Merge the next branch into master
  5. Release CI will tag the existing x.x.x@next NPM package with @latest
    Screenshot 2023-03-21 at 13 28 05

But the GitHub release, will NOT be tagged as latest-release.

I would expect for the GitHub release to also be tagged similar to NPM.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked .releaserc and .github/workflows/release.yml, then reproduce the next release followed by merging next into master. Compare the GitHub release state before and after the merge with the NPM dist-tags; done means the existing GitHub release changes from pre-release to latest after the production release.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript
Domain
release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.