semantic-release / semantic-release/github
Templates without `<% return ... %>` in `successCommentCondition`/`failCommentCondition` have confusing behavior
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 534
- Forks
- 150
- Avg merge
- 1m
- Merged PRs (30d)
- 3
Description
I can't see any reason to use Lodash templates other than <% ... %> eval expressions for successCommentCondition/failCommentCondition. I think we can make it more elegant. Should we automatically wrap with <%/%> so that the user-supplied string can just contain the logic?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating how successCommentCondition and failCommentCondition process Lodash templates. Review the existing behavior and discussion, then establish the intended handling for strings without <% ... %> expressions; the work is done when the behavior is agreed and covered by appropriate regression tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100