segmentio / segmentio/analytics.js-integrations
[segmentio] Drop the event when message exceeds the maximum size
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Hi 👋 . Is there any reason why the segmentio integration doesn't drop the event when the message exceeds the maximum size as the analytics-ios and analytics-android SDKs do? Looking through the files it seems like this was actually considered a year ago.
https://github.com/segmentio/analytics.js-integrations/blob/a33206aac3dccf6b4c5b3166a0ebdb4fd23c5e5d/integrations/segmentio/lib/index.js#L377-L378
I'm willing to open a PR if that is still considered.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in integrations/segmentio/lib/index.js around the linked lines and compare the existing oversized-message handling with the behavior described for the analytics-ios and analytics-android SDKs. Confirm the intended behavior for messages over the maximum size, then add or update the relevant coverage so oversized events are handled consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100