segmentio / segmentio/analytics.js-integrations
Google Analytics Integration contains `includes` which is not compatible with IE
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Support is guaranteed for IE >= 9: https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/#internet-explorer-support
This is not compatible with IE: https://caniuse.com/#feat=array-includes
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open integrations/google-analytics/lib/index.js around line 703 and inspect the Google Analytics integration code using includes. Check the stated IE >= 9 support requirement and the linked compatibility reference; done means this path works for the supported IE versions without changing its intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- analytics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100