segmentio / segmentio/analytics.js-integrations
[hubspot] Hubspot adds url parameters making them invalid
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Migrated from #17 by @slowtokyo
I am having the issue as detailed in here: https://github.com/segmentio/analytics.js/issues/504 when I try to add a url parameter to a query string hubspot puts its queries in front of the existing queries thereby creating an invalid URL. I have found a way around this that doesn't impact my analytics, but shouldn't the Hubspot query strings be appended to the end of any existing query strings?
The URL I want to create:
https://foo.bar.co/#/register?__hstc=6222316.1d2b332e80357701bf2ef394e3a88e1b.1508536177681.1521725761504.1521729618139.158&__hssc=6222316.4.1521729618139&__hsfp=1692073022&plan=professional
The URL that I get:
https://foo.bar.co/?__hstc=6222316.1d2b332e80357701bf2ef394e3a88e1b.1508536177681.1521725761504.1521729618139.158&__hssc=6222316.11.1521729618139&__hsfp=1692073022#/register?plan=professional
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the HubSpot integration code that constructs URLs and reproduce the behavior with the two example URLs in the issue. Done means existing query parameters remain associated with the route and HubSpot parameters are appended without producing an invalid URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100