segmentio / segmentio/analytics.js-integrations

[nanigans] Pull Request #10: add support for custom parameters

Open
#371 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
125
Forks
136
Avg merge
2h 45m
Merged PRs (30d)
1

Description

Migrated from #10 by @sperand-io

To mirror the support we added on the server: https://github.com/segment-integrations/integration-nanigans/blob/master/lib/index.js#L144-L149

@hankim813 @f2prateek @tsholmes

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the migrated Pull Request #10 and the server implementation in lib/index.js, especially lines 144-149, to understand the existing custom-parameter support. Trace the corresponding analytics.js integration entry point and confirm that it mirrors the server behavior, with tests or integration behavior covering custom parameters.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.