[vero] Pull Request #6: Feature/page view adding segment properties

Open
#341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
analytics

Research direction

Review the migrated Pull Request #6 and the Vero integration's page call first. Determine which segment properties the feature is intended to pass and how the existing implementation attempts to stub them. Done means the page-view properties are stubbed correctly and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Description

Migrated from #6 by @wethu

Hey People,

We're changing the properties tracked along with page views. I have some implementation here which works, however I'm having trouble stubbing the properties passed into page.

Thanks!

Dominant language
JavaScript
Stars
125
Forks
136
Avg merge
2h 45m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from segmentio/analytics.js-integrations

All issues in segmentio/analytics.js-integrations

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.