[vero] Pull Request #5: Update group and unsubscribe for parity with server-side integration INT-566

Open
#340 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
api

Research direction

Compare the Vero integration's unsubscribe and group-trait behavior with the server-side integration described in the issue, and review the migrated pull request linked in the body. Done means unsubscribe uses the identified user's id in the proper format and group traits achieve parity without relying on the undocumented update API.

Written by the indexing model from the issue text.

Description

Migrated from #5 by @tsholmes

The unsubscribe call was non-functioning. I updated it to use the id of the identify-d user and send it in the proper format.

The server-side integration calls an undocumented api to update a user with the group traits. We just re-identify the user with the group traits, and vero merges them internally.

Dominant language
JavaScript
Stars
125
Forks
136
Avg merge
2h 45m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from segmentio/analytics.js-integrations

All issues in segmentio/analytics.js-integrations

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.