segmentio / segmentio/analytics.js-integrations

[google-tag-manager] Pull Request #15: Gracefully fail on window.dataLayer name conflict

Open
#282 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
125
Forks
136
Avg merge
2h 45m
Merged PRs (30d)
1

Description

Migrated from #15 by @Peripheral1994

I'm updating the body of this PR to do some testing, don't mind me - Carlos

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the migrated Pull Request #15 and the google-tag-manager integration context first. Confirm the expected behavior when the window.dataLayer name conflicts, then add or update coverage for graceful failure and verify the integration tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.