segmentio / segmentio/analytics.js-integrations
[google-analytics] useGoogleAmpClientId should be useAmpClientId
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Migrated from #79 by @westcoastbias
currently the ga creation with useGoogleAmpClientId set to true looks like this:
Running command: ga("create", "UA-81924801-3", {cookieDomain: "none", siteSpeedSampleRate: 1, sampleRate: 100, allowLinker: true, useGoogleAmpClientId: true})
GA debugger chrome tool throws the following warning:
Create config had an unknown parameter: "useGoogleAmpClientId"
Based on google's documentation on implementing AMP (https://support.google.com/analytics/answer/7486764), the field should be "useAmpClientId". Example from the docs:
ga('create', 'UA-XXXXX-Y', 'auto', {'useAmpClientId': true});
This results in different client ids being used for AMP vs non-AMP events, which results in two separate sessions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating useGoogleAmpClientId in the Google Analytics integration and compare its configuration with the linked Google AMP documentation. Replace the outdated parameter name with useAmpClientId, then verify that AMP and non-AMP events use the intended client ID behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- analytics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 56/100