segmentio / segmentio/analytics.js-integrations
[google-analytics] Google Analytics Integration extractCheckoutOptions bug, Impact Checkout Step Viewed and Completed
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Migrated from #36 by @nickrathwell
Base on the documentation:
https://segment.com/docs/spec/ecommerce/v2/#checkout-step-viewed
https://segment.com/docs/spec/ecommerce/v2/#checkout-step-completed
The checkout options are to be returned in this format:
analytics.track('Checkout Step Completed', {
checkout_id: '50314b8e9bcf000000000000',
step: 2,
shipping_method: 'Fedex',
payment_method: 'Visa'
});
However the Google Analytics Integration is coded to look for these value in that format
analytics.track('Checkout Step Completed', {
checkout_id: '50314b8e9bcf000000000000',
step: 2,
shipping_method: 'Fedex',
payment_method: 'Visa'
});
function extractCheckoutOptions(props) {
var options = [
props.paymentMethod,
props.shippingMethod
];
// Remove all nulls, and join with commas.
var valid = reject(options);
return valid.length > 0 ? valid.join(', ') : null;
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/index.js around extractCheckoutOptions at the referenced line, then trace how checkout step events pass their properties into the integration. Compare the documented checkout payload with the property names the function reads; done means Checkout Step Viewed and Checkout Step Completed produce the intended checkout options.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- analytics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100