segmentio / segmentio/analytics.js-integrations
[appboy] Pull Request #37: Wrap suspect changeUser calls in try/catch
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Migrated from #37 by @ucarion
It appears likely that calls to changeUser in this integration, aside from that of identify, are not doing anything for this integration.
In an effort to demonstrate that it is precisely these changeUser calls which raise errors in the integration, this PR wraps these calls in try/catch. If this causes a reduction in errors from the integration, as is expected, then a follow-up PR will remove the calls to changeUser altogether. Otherwise, this PR will be rolled back.
To clarify: this PR is not meant to create a final state for the integration.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the appboy integration's changeUser calls, especially those outside identify, and the migrated Pull Request #37 context. Confirm whether the try/catch experiment is still applicable and what error reduction would count as success; the issue states that it is not a final state and expects a follow-up removal or rollback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100