segmentio / segmentio/analytics.js-integrations
[appboy] Only call changeUser when userID exists
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 125
- Forks
- 136
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 1
Description
Migrated from #22 by @dwillislc
When an identify, orderCompleted, page or track call is made without an userID, the mapping file is still attempting to call changeUser. This is resulting in a non-fatal error in the console log:
I see in Segment's documentation that adding a userID is optional for both the Identify and Track call, so it would be great if we could add some conditional logic:
if (userId) {
window.appboy.changeUser(userId);
}
Thanks much!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Appboy mapping file and trace the identify, orderCompleted, page, and track calls when no userID is provided. Verify that changeUser is not called without a userID and that calls with a userID still invoke it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100