sefe / sefe/dorc

UX: checkbox labels should reference input id so label text is clickable

Open
#708 0 comments 1 reaction 2 assignees View on GitHub

@benhegartysefe is already working on this.

Since May 28, 2026.

  • #709 by @copilot-swe-agent — open
enhancement
Dominant language
C#
Stars
5
Forks
3
Avg merge
1d 22h
Merged PRs (30d)
14

Description

Request

From Nishil Raichura:

lads just a small UX request in DORC if you agree

you see the label — the for should be pointing to the element Id rather than the type

if I rename it to the Id, it will allow me to click on the text to check the box, not just the actual small checkbox

just something to consider

Problem

In the Deploy screen (Components tree, e.g. Big Boy Deployables → BigBoy Windows 11, ELK BigBoy, etc.), each component checkbox is rendered with a <label> whose for attribute references the input's type/name rather than the input's unique id. As a result, clicking the visible label text doesn't toggle the checkbox — only the small checkbox itself is a hit target.

Suggested change

Render the <label for="..."> so it matches the corresponding <input id="..."> (the unique element id, e.g. including the data-componentId). Once for and id match, the standard browser behavior makes the label text a clickable hit target for the checkbox, which significantly improves the click target size and matches user expectations for form labels.

Acceptance

  • Clicking the component name text in the Deploy → Components tree toggles the associated checkbox.
  • Same fix applied anywhere else in DORC where component/deployable checkboxes are rendered with the same for/id mismatch.

Reported in Teams chat 2026-05-28.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.