Clean up legacy RefDataServices acceptance tests + dead endpoint enum value
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 5
- Forks
- 3
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 14
Description
Background
PR #651 modernised the daemons feature, replacing the legacy /RefDataServices endpoint with /RefDataDaemons and renaming the related core classes to DaemonStatusProbe / IDaemonStatusProbe. Two pieces of legacy scaffolding were intentionally left untouched in that PR to keep its scope tight:
src/Tests.Acceptance/Features/RefDataServices.featuresrc/Tests.Acceptance/StepDefinitions/RefDataServicesSteps.csEndpoints.RefDataServicesenum value insrc/Tests.Acceptance/Support/Endpoints.cs
The feature file and step bindings are [@ignore] / [Ignore]-marked and still reference the removed RefDataServices PUT endpoint and ServiceName / ServiceStatus parameter labels. They are dead code today.
Scope
Decide and execute one of:
- Delete the dormant feature, step file, and enum value (recommended — the endpoint they cover no longer exists).
- Re-target them to
Endpoints.RefDataDaemonswithDaemonName/DaemonStatusparameter labels and remove the[Ignore]markers, restoring real coverage of the daemon state-change PUT.
Option 2 only makes sense if the original test intent (PUT to change daemon state) is still worth covering at the acceptance layer; otherwise option 1 is cleaner.
Acceptance criteria
- Decision recorded on the issue (delete vs. re-target).
- No remaining
\bServiceStatus\b/\bIServiceStatus\b/RefDataServicesreferences insrc/. - If re-targeted: tests pass against a running stack.
- If deleted: solution still builds and the rest of
Tests.Acceptancestill runs green.
References
- Origin PR: #651 (Modernise daemons: deploy.* schema, RBAC, audit, UX — #649)
- Kirill review comment that prompted the rename: https://github.com/sefe/dorc/pull/651#discussion_r3146667000
- Reply explaining what was deferred: https://github.com/sefe/dorc/pull/651#discussion_r3146773549
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR #651 and the three named files: RefDataServices.feature, RefDataServicesSteps.cs, and Support/Endpoints.cs. Search src/ for RefDataServices, ServiceStatus, and IServiceStatus, then choose whether to delete the dormant coverage or retarget it. Done means no legacy references remain and the solution plus Tests.Acceptance still builds and runs green; retargeting also requires a running-stack test pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100