sefe / sefe/dorc

Add CancellationToken propagation to IBuildServerClient async methods

Open
#592 0 comments 0 reactions 2 assignees View on GitHub

@kirill-suspitsin-ext-sefe is already working on this.

Since Jun 10, 2026.

  • #607 by @smurugan-sefe — open
enhancement
Dominant language
C#
Stars
5
Forks
3
Avg merge
1d 22h
Merged PRs (30d)
14

Description

Background

IBuildServerClient defines async methods (GetBuildsAsync, GetBuildArtifactDownloadUrlAsync, ValidateBuildAsync) but none accept a CancellationToken. Long-running GitHub API calls cannot be cancelled when a request is aborted.

Recommended Approach

  1. Add CancellationToken cancellationToken = default to all async methods on IBuildServerClient
  2. Pass the token through to all HttpClient calls in GitHubActionsBuildServerClient
  3. Pass from ASP.NET controller actions via HttpContext.RequestAborted
  4. Update AzureDevOpsBuildServerClient to pass the token to its underlying client

Identified in multi-model review of PR #584 and PR #585

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.